Thanks

Vic

Thanks!


($pop->date - $first_date) / $pop->date



($pop->date - $first_date) / $pop-$gt;date


should read


($pop->date - $first_date) / $pop-$>date


In the first SQL statement, you are asking mysql to send back the entire row for each post in the database, including the post body, and a bunch of other information you don’t need. On a busy blog with lots of posts, this might slow things down a bit.

I’m not sure how the popularity contest table is structured, but wouldn’t $total be the same as $total_popularity?

$total_posts seems to only used in the else block, maybe the value could be retrieved in the else block as well to save an unnecessary SQL query?

In the if block,

(($pop->date - $first_date) / $date_diff) * ($date_diff / $pop->date)

could be written as

($pop->date - $first_date) / $pop-$gt;date


The elements in $big_array for the else block could be post ids, like in the if block, instead of as arrays.

It would be more efficient if you krsorted and popped (array_pop) a value from the $big_array after each value was added (except the first one), instead of sorting a huge array at the end. Or if you stored $max_post_id and $max_post_weighted_value (with less verbose variable names, of course) and compared each post’s weight to them, replacing the $max… variables with the current post’s id and weighted value if it’s weighted value is greater.

Overall, there is nothing urgent here, just some things to keep in mind in the future if you choose to.

Keep up the great work.